Skip to content

prerequisites: update node version to 14 #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

prerequisites: update node version to 14 #675

merged 1 commit into from
Apr 21, 2023

Conversation

aspeddro
Copy link
Collaborator

Since 10.1.0 ReScript requires node v14.

The format command raise an error.

./node_modules/.bin/rescript format src/let_binding.res

Uncaught Exception { Error: Cannot find module 'node:util'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/pedro/Desktop/learning-rescript/node_modules/rescript/scripts/rescript_format.js:8:12)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3) code: 'MODULE_NOT_FOUND' }

ReScript: 10.1.0
Node: v10.24.1

The format command only works with node v14.

CHANGELOG

@cristianoc cristianoc requested a review from ryyppy April 19, 2023 03:17
@aspeddro aspeddro mentioned this pull request Apr 20, 2023
Closed
@ryyppy
Copy link
Member

ryyppy commented Apr 21, 2023

Should be fixed with rescript-lang/rescript#6186

I will still merge this requirement, since Node v10 for an application really is pretty outdated and the Vercel deployment currently runs on v16.

@ryyppy ryyppy merged commit 9d55261 into rescript-lang:master Apr 21, 2023
@aspeddro aspeddro deleted the fix-node-version branch May 5, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryyppy ryyppy Awaiting requested review from ryyppy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspeddro @ryyppy